Try fetching remote forkpoint.toml and validators.toml on startup #2484
+247
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamrith
requested review from
ariqchowdhury,
michael-yxchen and
omegablitz
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to fetch remote forkpoint and validators configuration files on node startup, falling back to local configs if remote fetching fails. The node compares remote and local forkpoint rounds to determine which is more recent.
- Introduces environment variables for remote config URLs and HTTP client logic to fetch configurations
- Refactors config loading to prioritize more recent remote configs over local ones
- Updates struct fields to use parsed validators config instead of file path
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| monad-node/src/state.rs | Adds remote config fetching logic with round-based comparison and fallback to local configs |
| monad-node/src/main.rs | Removes redundant validators config loading by using pre-loaded config from NodeState |
| monad-node/Cargo.toml | Adds reqwest dependency with blocking feature for HTTP requests |
| monad-node-config/src/lib.rs | Introduces ValidatorsConfigType alias for type consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bamrith
force-pushed
the
bharath/fetch_toml_files
branch
6 times, most recently
from
d04761a to
cfd0f2e
Compare
bamrith
force-pushed
the
bharath/fetch_toml_files
branch
from
cfd0f2e to
8173fd2
Compare
ariqchowdhury
previously approved these changes
Nov 3, 2025
bamrith
force-pushed
the
bharath/fetch_toml_files
branch
from
8173fd2 to
156af23
Compare
michael-yxchen
approved these changes
Nov 6, 2025
bamrith
force-pushed
the
bharath/fetch_toml_files
branch
from
156af23 to
b2625ea
Compare
ariqchowdhury
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.